Skip to content

feat_favorites_filter#1985

Open
Mbeaulne wants to merge 1 commit into03-23-feat_favorites_homepage_sectionfrom
03-23-feat_favorites_filter
Open

feat_favorites_filter#1985
Mbeaulne wants to merge 1 commit into03-23-feat_favorites_homepage_sectionfrom
03-23-feat_favorites_filter

Conversation

@Mbeaulne
Copy link
Copy Markdown
Collaborator

@Mbeaulne Mbeaulne commented Mar 23, 2026

Description

Added search functionality to the Favorites section, allowing users to filter favorites by name or ID. The search input includes a search icon and a clear button that appears when there's a query. The pagination logic has been updated to work with filtered results, automatically resetting to the first page when searching.

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

  1. Navigate to the Home page with existing favorites
  2. Verify the search input appears above the favorites list
  3. Type in the search field to filter favorites by name or ID
  4. Confirm the clear button (X) appears when typing and clears the search when clicked
  5. Test pagination with filtered results to ensure it resets appropriately
  6. Verify case-insensitive search functionality works correctly

Additional Comments

The search functionality filters favorites in real-time and automatically resets pagination to the first page when the search query changes. The search is case-insensitive and matches both favorite names and IDs.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 23, 2026

🎩 To tophat this PR:

You can add the following URL parameter to your browser to tophat this PR:

`?tophat_location=03-23-feat_favorites_filter/dabe28b`

@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_filter branch from fbe7ca9 to dabe28b Compare March 27, 2026 13:52
@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_homepage_section branch from 3979743 to 2622e15 Compare March 27, 2026 13:52
@Mbeaulne Mbeaulne mentioned this pull request Mar 27, 2026
8 tasks
@Mbeaulne
Copy link
Copy Markdown
Collaborator Author

Reviewer note: This PR adds a search filter to FavoritesSection.tsx — the same chip-based component that is deleted in #1996 and again in #1998. This change doesn't survive the stack.

The final favorites view is in DashboardFavoritesView.tsx (built in #1998). Feel free to skim this one.

@Mbeaulne Mbeaulne marked this pull request as ready for review March 30, 2026 18:23
@Mbeaulne Mbeaulne requested a review from a team as a code owner March 30, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant